hypothesis / hypothesis/via

Fix manifest URL rewriting

Open
#288 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
29
Forks
13
PR merge metrics
No merged PRs in 30d

Description

We don't rewrite URLs in `manifest.json` files: https://twitter.com/bascule/status/1307440596668182528?ref_src=twsrc%5Etfw%7Ctwcamp%5Etweetembed%7Ctwterm%5E1307440596668182528%7Ctwgr%5Eshare_3&ref_url=https%3A%2F%2Fwww.theguardian.com%2Ftechnology%2F2020%2Fsep%2F21%2Ftwitter-apologises-for-racist-image-cropping-algorithm

This causes problems for certain websites. We have actually taken steps to prevent `pywb` from rewriting manifest files at all, as it was adding all the javascript stuff to some of them.

Long story short, this might not be possible, but could enable some big sites like twitter.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.