hypothesis / hypothesis/support-legacy

[HTML & API] Incorrect title and incorrect URI lookup with https://www.rfc-editor.org URL

Open
#256 5 comments 0 reactions 0 assignees View on GitHub
document equivalence
Dominant language
No language data
Stars
3
Forks
0
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
- Bookmarking RFCs from [The RFC Editor](https://www.rfc-editor.org) creates annotations pointing to one specific RFC (RFC 8783).

- Also, all RFC Editor RFCs are bookmarked with the same title : _RFC 8783: Distributed Denial-of-Service Open Threat Signaling (DOTS) Data Channel Specification_

- At last, annotations linked to the RFC URL appear as orphan although they exist.

**To Reproduce**
Steps to reproduce the behavior:
1. Go to https://www.rfc-editor.org/rfc/rfc8984.html
2. Click on the bookmarklet
3. Notice orphan annotations
4. Bookmark the RFC
5. The bookmarked RFC is titled _"RFC 8783: Distributed Denial-of-Service Open Threat Signaling (DOTS) Data Channel Specification"_ instead of _"RFC 8984 JSCalendar: A JSON Representation of Calendar Data"_
6. API searching for annotations with the RFC URL returns annotations with other RFC (see `annotation.uri` and `annotation.target.source[0]`): https://api.hypothes.is/api/search?uri=https://www.rfc-editor.org/rfc/rfc8984.html

**Expected behavior**
* HTML: Bookmarking a RFC should create annotations with a correct title based on the bookmarked RFC and not from RFC 8783.
* API: An API search using a RFC Editor URL should only return annotations targeting the `uri` parameter and not all bookmarked RFCs from the RFC Editor.

**Additional comment**

The HTML code of the [page](https://www.rfc-editor.org/rfc/rfc8984.html) doesn't contain a canonical URL but the following metadata:
```html

```

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reproducing the bookmarklet flow on the RFC 8984 HTML page and the API search using its RFC Editor URL. Compare the extracted title, annotation target URI, and the page metadata shown in the issue with RFC 8783 results; done means RFC 8984 gets its own title and annotations, and the API search returns only that URI's annotations.

Written by the indexing model from the issue text.

Assessment

Tech stack
html
Domain
api, web-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.