hypothesis / hypothesis/support-legacy

SPIKE: Remove "Open" button from PDF.js

Open
#202 1 comment 0 reactions 0 assignees View on GitHub
accessibility feature request
Dominant language
No language data
Stars
3
Forks
0
PR merge metrics
No merged PRs in 30d

Description

PDF.js includes an icon in the toolbar for opening a new PDF in the viewer.

Using this feature while Hypothesis is active results in a confusing experience for the user:
- The new PDF is loaded in the viewer, but annotations from the previously shown PDF still display in the sidebar
- User can annotate in the new document, with new annotation added in the sidebar with the old

This is especially unwanted in the LMS app, where a instructor has assigned a specific document and there should not be any opportunity for a student to open a different document in the same viewer.

Screen Shot 2021-05-13 at 3 45 11 PM

Contributor guide

No contributing guide indexed for this repository

Research direction

The issue identifies PDF.js's toolbar Open button and the Hypothesis sidebar behavior, but names no repository files, tests, or entry points. Start by locating the viewer toolbar configuration and checking the LMS viewer behavior; done means the Open control is unavailable and changing documents cannot retain annotations from the previous document.

Written by the indexing model from the issue text.

Assessment

Domain
frontend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.