hypothesis / hypothesis/product-backlog

Remove share widget exclusion for elife

Open
#882 10 comments 0 reactions 1 assignee Claimed by @robertknight View on GitHub
elife
Dominant language
No language data
Stars
122
Forks
7
PR merge metrics
No merged PRs in 30d

Description

## Feature Request Form
### Problem you are trying to address with this feature

There is no share button for the elife implementation.

This commit:
https://github.com/hypothesis/client/commit/d11be3fb0ac168d80c65603bad4b735bd455200b

Removed this capability, but only for their authority. Per the commit message:

> Don't show the "Share this page" button in the top-right of the sidebar
> on pages, such as eLife's, that have both an embedded Hypothesis client
> and a services config including their own `authority` string.
>
> The "Share this page" button is a Via link, and Via doesn't work with
> pages using a third-party authority config.

### Your solution

Now that we use bouncer links in the share widget, as of this PR https://github.com/hypothesis/client/pull/748 and also now that we can whitelist sites embedding H per this PR https://github.com/hypothesis/bouncer/pull/155, we should remove this exception.

Also, note that we will presumably need to add elife to the bouncer/embed_detector.py at the same time.

### Add tags - did you add labels?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.