hypothesis / hypothesis/product-backlog

Inconsistent lozenge display names

Open
#44 5 comments 0 reactions 0 assignees View on GitHub
activity pages
Dominant language
No language data
Stars
122
Forks
7
PR merge metrics
No merged PRs in 30d

Description

The display of groups, users and tags on search lozenges is inconsistent in two ways:

1. Sometimes the single-word usernames are shown and sometimes the multi-word user display names
2. Sometimes they are wrapped in quotes and sometimes not

Also, group names are shown in lozenges but what you have to actually type into the search box if trying to create a group lozenge by typing manually is the group's pubid not its name.

Currently If I go to a user's search page their display name (if they have one) is shown in the lozenge:

![screenshot from 2016-11-16 21-02-14](https://cloud.githubusercontent.com/assets/22498/20365760/07f60b5e-ac40-11e6-87d9-804b1d0491d0.png)

But if I go to a group's page, the usernames in the sidebar use the usernames not the display names:

![screenshot from 2016-11-16 21-03-21](https://cloud.githubusercontent.com/assets/22498/20365789/2a310070-ac40-11e6-9dc4-b6b389ec6779.png)

Also the lozenge that gets created if I click on one of those usernames will show the username not the displayname (this is a difference between lozenges that are rendered server-side, and ones that are created by JavaScript):

![screenshot from 2016-11-16 21-04-31](https://cloud.githubusercontent.com/assets/22498/20365824/57e38362-ac40-11e6-8ca5-523548e49ddd.png)

If I wanted to manually type in a lozenge for this use I would have to type in `user:seanh`, neither `user:Sean Hammond` nor `user:"Sean Hammond"` would work.

If I go to a group's page then the group's name is displayed in the lozenge, without quotes:

![screenshot from 2016-11-16 21-06-11](https://cloud.githubusercontent.com/assets/22498/20365871/919fef46-ac40-11e6-9158-a478186f808f.png)

But if I create a lozenge for this group by selecting it from the dropdown menu then it does have quotes around the name, and then when I hit `Enter` to submit the search the quotes disappear:

![peek 2016-11-16 21-07](https://cloud.githubusercontent.com/assets/22498/20365927/d27522de-ac40-11e6-8258-b8fe374bd7ca.gif)

If trying to manually type in a lozenge for this group, neither `group:Hypothesis Reading` nor `group:"Hypothesis Reading"` would work, I'd need to type in `group:xyz123`.

Tag lozenges created by selecting a tag suggestion from the dropdown menu, do not have quotes around the tag:

![screenshot from 2016-11-16 21-11-49](https://cloud.githubusercontent.com/assets/22498/20366041/592f687a-ac41-11e6-9ab3-24d3c3ea57dc.png)

Also when tags are shown in the sidebar, and when tag lozenges are added to the search query by selecting one from the sidebar - they are always displayed without quotes/

If I wanted to type in a multi-word tag facet though, I would have to use quotes `tag:"multi word tag"` and _then_ it would be rendered with quotes:

![screenshot from 2016-11-16 21-13-56](https://cloud.githubusercontent.com/assets/22498/20366182/daf59834-ac41-11e6-959f-8accfb7e4223.png)

The existence of such a multi-word tag seems to break the sidebar:

![screenshot from 2016-11-16 21-14-46](https://cloud.githubusercontent.com/assets/22498/20366173/d525e990-ac41-11e6-9448-effd1b58b47d.png)

I haven't tested how multi-word tags are displayed in the dropdown menu, or what happens when you click on one from the dropdown menu.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.