hypothesis / hypothesis/lms

Don't create H groups for empty (null) GUIDs

Open
#6,613 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
53
Forks
16
Avg merge
14d 5h
Merged PRs (30d)
14

Description

See https://github.com/hypothesis/lms/pull/6612 for examples of the problem.

[We don't seem to have launches from AI without a GUID.](https://metabase.hypothes.is/question#eyJkYXRhc2V0X3F1ZXJ5Ijp7InR5cGUiOiJuYXRpdmUiLCJuYXRpdmUiOnsicXVlcnkiOiJzZWxlY3QgKiBmcm9tIGFwcGxpY2F0aW9uX2luc3RhbmNlcyB3aGVyZSB0b29sX2NvbnN1bWVyX2luc3RhbmNlX2d1aWQgaXMgbnVsbCBhbmQgbGFzdF9sYXVuY2hlZCA-PSAnMjAyMi0wMS0wMSdcbiAgICAgICAgXG4gICAgICAgIFxuICAgICAgICBcbiIsInRlbXBsYXRlLXRhZ3MiOnt9fSwiZGF0YWJhc2UiOjd9LCJkaXNwbGF5IjoidGFibGUiLCJwYXJhbWV0ZXJzIjpbXSwidmlzdWFsaXphdGlvbl9zZXR0aW5ncyI6e319)

This might be an issue for first launches on application instances where we don't correctly use the GUID from the launch and pick the old (null) value from the DB instead.

We currently check on every launch that the GUID has not changed, also include here a check to avoid cointinue for empty GUIDs just in case.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.