hypothesis / hypothesis/lms

Validate LMS URL's on the /welcome page

Open
#592 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
53
Forks
16
Avg merge
14d 5h
Merged PRs (30d)
14

Description

The `/welcome` form has basically no validation of the LMS URL at all, even though this is the base URL that we used to construct Canvas API URLs in order to use the Canvas API.

- [ ] Add validation to the `/welcome` form so that invalid URLs can no longer be entered.

We should at least test, server-side, that it appears to be a valid URL and we can parse it into the parts that we need for constructing API URLs. Trying to do more than that is probably taking it too far.

- [ ] Do something about existing bad data in the QA and production DBs.

I'm not sure what the correct solution is. Maybe delete all invalid LMS URLs from the DB (those application instances will then have the Canvas Files feature disabled, but the feature can't be working anyway).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.