hypothesis / hypothesis/lms

Make the dialog buttons for URL and FilePicker the same

Open
#2,280 1 comment 0 reactions 1 assignee Claimed by @LMS007 View on GitHub
Dominant language
Python
Stars
53
Forks
16
Avg merge
14d 5h
Merged PRs (30d)
14

Description

Currently the Submit button is disabled for the file picker, but not for the URL picker. Instead, the URL picker has a client-side popup message explaining that it won't work until you pick a URL.

We should adopt this behavior for both dialogs. The file picker is a bit confusing because the disabled styling looks like the enabled cancel button. So its unclear it cannot be clicked and then if you click it it, it's also unclear why it does not work. Additionally, making these 2 dialogs behave the same improves consistency.

![Dec-07-2020 14-40-04](https://user-images.githubusercontent.com/3939074/101414486-0337b180-389b-11eb-9514-cfa508d3cee5.gif)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.