hypothesis / hypothesis/lms

Provide error details in auth error dialog if Canvas developer secret is wrong

Open
#1,887 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
53
Forks
16
Avg merge
14d 5h
Merged PRs (30d)
14

Description

If an LMS app installation is configured with an incorrect developer secret, the Canvas authorization process fails without a useful error message:

1. Launch the assignment in the "Wrong Developer Secret" course at https://hypothesis.instructure.com/courses/120/assignments/848
2. Click the "Authorize" button when prompted during the assignment launch
3. Click "Authorize" in the popup dialog

Result:

Screenshot 2020-07-08 at 11 31 15

Clicking on the "email support" link opens an email with a blank body.

Ideally this dialog should include some hint as to what exactly went wrong. If Canvas doesn't provide us with that information then perhaps we can still include something useful to narrow the range of possibilities.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.