hypothesis / hypothesis/h

Make Session's `group`s use Group presenter

Open
#8,606 0 comments 0 reactions 1 assignee Claimed by @lyzadanger View on GitHub
Dominant language
Python
Stars
3.2k
Forks
459
Avg merge
27d 1h
Merged PRs (30d)
1

Description

There's some technical debt from legacy behavior in the `session` module in which `session` decorates its `groups` dicts differently than the new Groups presenter. The net result is that groups returned by `GET /api/profile`, while the same actual _list_ as of https://github.com/hypothesis/h/pull/4818 have different _properties_ from those returned by `GET /groups`(see http://h.readthedocs.io/en/latest/api-reference/ if you are curious). In addition, `session` still uses outdated logic that does not return activity-page URLs for open groups.

The reason that this hasn't been changed is that a number of web pages—non-client—in `h` make use of `session.profile` and its groups and I wanted to be careful about making changes that could break current functionality. But now is perhaps the time!

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.