hypothesis / hypothesis/h

Crash when handling publisher-generated JWT grant token with invalid account ID

Open
#5,661 2 comments 0 reactions 0 assignees View on GitHub
bug S4 Sentry 💥
Dominant language
Python
Stars
3.2k
Forks
459
Avg merge
27d 1h
Merged PRs (30d)
1

Description

https://sentry.io/organizations/hypothesis/issues/1106040600/

A crash occurs if a publisher with keys for an authority generates a grant token for an invalid user ID (eg. `acct:@authority`) and the client POSTs it to the `/api/token` route.

In one of the reports in the linked Sentry issue, the contents of the JWT token submitted to the endpoint was:

```json
{
"aud": "hypothes.is",
"iss": "d9bb38d6-9c38-11e9-9718-935e4c0dc38c",
"sub": "acct:@h.jonudell.info",
"nbf": 1563383764,
"exp": 1563384364
}
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.