hypothesis / hypothesis/h

meta name="dc.identifier" content="https://dx.doi.org/..." yields unexpected equivalence result

Open
#5,359 0 comments 0 reactions 0 assignees View on GitHub
bug document equivalence
Dominant language
Python
Stars
3.2k
Forks
459
Avg merge
27d 1h
Merged PRs (30d)
1

Description

Here is a set of equivalences created using `` and ``

![image](https://user-images.githubusercontent.com/46509/46752688-b7652f80-cc72-11e8-8c44-38fa4b1a7e62.png)

And here is the set created using ``

![image](https://user-images.githubusercontent.com/46509/46752941-51c57300-cc73-11e8-8f4c-da79b5836114.png)

In both cases, the _dc.identifier_ value matches this server-side pattern:

https://github.com/hypothesis/h/blob/682764d8bbf46c9d8045162493b777484069fe57/h/util/document_claims.py#L28.

But the DOI-style URI generated in the second case doesn't match the one generated in the first case, and we end up with two disjoint sets of annotations.

We currently have ~15K `document_uri` records like `doi:10.1000/...' and ~2K like `doi:http(s)://dx.doi.org/10.1000/...`

This likely isn't much of a problem because most publishers asserting DOIs use both the Highwire and DC syntaxes. But it's something to be aware of.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.