hypothesis / hypothesis/h

Incorrect handling of URL fragments in `/api/badge` endpoint

Open
#4,763 3 comments 0 reactions 0 assignees View on GitHub
API bug
Dominant language
Python
Stars
3.2k
Forks
459
Avg merge
27d 1h
Merged PRs (30d)
1

Description

These two curl commands should produce the same result since fragment identifiers in the URL should be ignored. However, they are producing different counts:

```
(h) ~/h/r/h > curl 'https://hypothes.is/api/badge?uri=https%3A%2F%2Fwww.npr.org%2F2018%2F02%2F01%2F582358540%2Fmuellers-reputation-in-washington-is-stunningly-bipartisan-journalist-says%23annotations%3A09EZTAfgEeib5F8c-2Vc6Q'
{"total": 26}

(h) ~/h/r/h > curl 'https://hypothes.is/api/badge?uri=https%3A%2F%2Fwww.npr.org%2F2018%2F02%2F01%2F582358540%2Fmuellers-reputation-in-washington-is-stunningly-bipartisan-journalist-says'
{"total": 1}⏎
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.