hypothesis / hypothesis/frontend-shared

Re implement `Menu` and its allies (from `client`)

Open
#995 0 comments 0 reactions 0 assignees View on GitHub
component
Dominant language
TypeScript
Stars
8
Forks
5
PR merge metrics
No merged PRs in 30d

Description

It is likely that alterations will be desirable to the `PublishAnnotationControl` component in the client, and/or a new menu added to annotation (thread) cards for upcoming projects.

`PublishAnnotationControl` currently uses `Menu*` components in the `client`, and any new menu would (unsurprisingly) also depend on `Menu` and its allies. These components function fine, but are not in line with our current UI conventions and are thus difficult to extend/adapt to new patterns.

In addition, `Menu` uses a hook-like component to manage keyboard navigation currently, which is unconventional. I believe this could be supplanted with this package's `useArrowKeyNavigation` hook.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.