hypothesis / hypothesis/frontend-shared

"Feedback" components directory contains unrelated components

Open
#1,905 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
8
Forks
5
PR merge metrics
No merged PRs in 30d

Description

The [`components/feedback`](https://github.com/hypothesis/frontend-shared/tree/main/src/components/feedback) directory contains components which represent some kind of operation progress (spinners, notifications etc.) which I think was the original meaning. However it also has dialogs and popovers which don't fit the intent of the category.

Proposed solution: Move all the dialog components, including popovers, to a separate directory.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.