hypothesis / hypothesis/frontend-shared

Make `ToastMessages` `onMessageDismiss` prop receive the message object

Open
#1,273 0 comments 0 reactions 0 assignees View on GitHub
breaking
Dominant language
TypeScript
Stars
8
Forks
5
PR merge metrics
No merged PRs in 30d

Description

As implemented in https://github.com/hypothesis/frontend-shared/pull/1272, the `onMessageDismiss` prop is a callback that receives the message to be dismissed id.

This is consistent to how frontend apps have been using this kind of component, but requires duplicating extra logic in order to determine which message was dismissed.

For next major release we want to change this so that the whole message is passed to the callback.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.