hypothesis / hypothesis/client

Can't open sidebar when annotation target is a link

Open
#790 7 comments 0 reactions 0 assignees View on GitHub
bug design
Dominant language
Mustache
Stars
730
Forks
224
PR merge metrics
No merged PRs in 30d

Description

When an annotation targets a link, the link activates as normal, which means that we see the sidebar open just in time for the page to refresh with the new location. The only way to see such an annotation is to open the sidebar and find it there - no way to see those annotations from the text itself.

See current behavior here:
http://jonudell.info/h/highlight-coincides-with-link.mp4

### Steps to reproduce
1. Browse to http://conf.a11yto.com/playlist
2. Select "Public" from group selector if not already selected
3. Click on any highlighted link (talk titles are good examples)

### Expected behaviour
Need to figure this out - one approach might be to stop propagation of the click and show a clickable link so that it's still navigable, similar to Google Docs:

![screen shot 2018-10-16 at 5 03 38 pm](https://user-images.githubusercontent.com/1348738/47095021-34e3ef00-d1e1-11e8-8b21-8f1e5660e418.png)
### Actual behaviour
Sidebar opens, but page immediately navigates to new URL.

### Browser/system information
macOS Mojave/Chrome

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.