hypothesis / hypothesis/client

apiUrl config setting shouldn't require trailing slash

Open
#783 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
Mustache
Stars
730
Forks
224
PR merge metrics
No merged PRs in 30d

Description

If the client's `services[0].apiUrl` config setting is `http://localhost:5000/api` then the client will incorrectly try to use `http://localhost:5000/token`, get a 404 response from h, and show a "Hypothesis login lost" error. `http://localhost:5000/api/` works correctly -- the client uses `http://localhost:5000/api/token`.

Expected behaviour: `http://localhost:5000/api/token` should be used regardless of whether or not `apiUrl` ends with a trailing `/`.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.