hypothesis / hypothesis/client
Empty `dc:title` metadata field in PDFs should be ignored
Open
bug
- Dominant language
- Mustache
- Stars
- 730
- Forks
- 224
- PR merge metrics
- No merged PRs in 30d
Description
I created an annotation on http://awspntest.apa.org/fulltext/2018-18843-001.pdf. It shows up untitled in activity pages:
Here's why: http://jonudell.net/h/apa-untitled-document.mp4
It happens [here](https://github.com/hypothesis/client/blob/734e3a25318364819a8c38ef881e4788a2b06365/src/annotator/plugin/pdf-metadata.js#L83). We acquire the HTML doctitle as expected, but then overwrite it because `dc:title` exists in HTML metadata, even though it's empty.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.