hypothesis / hypothesis/client

Incorrect Conversion of Overlapping Highlights or Notes Upon Page Navigation

Open
#6,348 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
Mustache
Stars
730
Forks
224
PR merge metrics
No merged PRs in 30d

Description

Bug Description:
When overlapping highlights or notes occur in the Hypothesis client, navigating between pages causes the overlapped words to be mistakenly converted into either highlights or notes. This issue specifically arises when a note is applied to a word that is already highlighted or vice versa, and then navigating to another page and returning to the original page.

Steps to Reproduce:
-> Highlight two words.
-> Add a note to the first word, which is already highlighted.
-> Navigate to another page and then return to the original page.
-> Observe that the entire two words may be converted into either highlights or notes.

Expected Behavior:
After navigation, the highlighted and noted words should remain intact without any conversion.

Before switching pages:

image

After switching pages:

image

Reference video:

https://github.com/hypothesis/client/assets/159520431/b87e2cf4-3571-416f-b70c-b2ff673a83bf

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.