hypothesis / hypothesis/client

Adder position doesn't update when scrollable container is scrolled

Open
#5,656 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Mustache
Stars
730
Forks
224
PR merge metrics
No merged PRs in 30d

Description

The Annotate/Highlight toolbar normally moves with the selection when the document is scrolled, but this doesn't work if a scrollable container within the document is scrolled, rather than the whole document.

**Steps to reproduce:**

1. Select some text in Via's video player
2. Scroll the transcript

**Expected result:** The adder toolbar should appear in step (1) and move with the selection in step (2)
**Actual result:**

The adder toolbar position stays fixed in step (2), becoming detached from the selection:

Detached adder

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.