hypothesis / hypothesis/client

Corrupts textarea field if its contents are annotated

Open
#5,376 2 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Mustache
Stars
730
Forks
224
PR merge metrics
No merged PRs in 30d

Description

I was demonstrating Hypothes.is to a colleague using the Tiki Wiki CMS Groupware web application engine. I annotated a word part of the default wiki page, then went on to modify the wiki page, to show that Hypothes.is deals with changes to the annotated text.

To my great surprise, in the textarea input field where one modifies the page's content, the annotated word disappeared. Saving the page did remove the annotated word from the page's content.

This happened with Tiki versions 15, 16 and 17, using Google Chrome versions 60 and 62 with extension versions 1.48.0.0 and 1.50.0.0, on 2 Windows machines. This reproduced whether the page's content was French or English. I however only reproduced this on local Tiki installations, except for a demonstration instance. I created [a page called "HomePage2"](http://jmorris-11758-6403.show.tikiwiki.org/tiki-index.php?page=HomePage2) in that instance using the default contents of Tiki's homepage.

To reproduce:

1. Create or edit a wiki page to contain the contents of the default homepage:
![hypothesis corruption before](https://user-images.githubusercontent.com/486141/32568739-2741863a-c48d-11e7-9919-6714ba0b58fc.png)
2. Activate the Hypothes.is extension
3. Select the word "configuring"
4. Submit any comment:
![hypothesis corruption during annotation](https://user-images.githubusercontent.com/486141/32568740-274e3024-c48d-11e7-9740-04c73cf61185.png)
5. Click Edit to go to tiki-editpage.php?page=HomePage:
![hypothesis corruption during edit](https://user-images.githubusercontent.com/486141/32568741-275bdfa8-c48d-11e7-801d-ed452dc770e9.png)
You will notice the word "configuring" disappearing during page load. If you save, you should see: ![hypothesis corruption after](https://user-images.githubusercontent.com/486141/32568738-2734ea38-c48d-11e7-8be1-6ecdbea6bea1.png)
If you then go to the history, you can confirm the corruption [comparing versions](http://jmorris-11758-6403.show.tikiwiki.org/tiki-pagehistory.php?page=HomePage2&newver=0&oldver=1):
![hypothesis corruption diff](https://user-images.githubusercontent.com/486141/32568743-2767077a-c48d-11e7-8f02-d63924091068.png)

The HTTP credentials to enter the demonstration instance are "show"/"show". The password for user admin is "12345".

I did not investigate why the word is removed.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.