hypothesis / hypothesis/client

DOM changes to insert highlights around text blocked in Notion

Open
#5,069 2 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Mustache
Stars
730
Forks
224
PR merge metrics
No merged PRs in 30d

Description

The selected highlight and the ability to scroll to the highlight by the H annotation client aren't working on Notion web pages-- presumably because our mutations that wrap text nodes in `` elements get stripped out.

We get console warnings like the following:

Screenshot 2022-12-14 at 6 41 37 AM

I noticed a similar issue on another project, which ultimately was resolved... possibly in the [new editor launched earlier in the year](https://twitter.com/notionhq/status/1483884489235255297?s=21)?:
https://github.com/obahareth/notion-rtl/issues/28#issuecomment-1017756589

Given that web annotation and the mechanisms to make it work on the DOM are a larger class of problem I'm curious if there are elegant ways of addressing this, possibly collaboratively between teams.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.