hypothesis / hypothesis/client

Inconsistent cursor style on hover

Open
#3,327 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Mustache
Stars
730
Forks
224
PR merge metrics
No merged PRs in 30d

Description

The client does not render the cursor styling for all clickable elements the same. I suspect this an oversite rather than intention, but If I'm close, please close ticket!

The cursor style is defined in reset.scss

```button,
html input[type='button'],
input[type='reset'],
input[type='submit'] {
cursor: pointer;
-webkit-appearance: button;
}
```

This does not capture all actual elements that behave like buttons. Specifically items in the menu which are not a `` but act like one, don't get styled

![Apr-23-2021 15-15-59](https://user-images.githubusercontent.com/3939074/115935270-ac94d380-a447-11eb-8117-4e3c89f39e35.gif)

We should consider removing `button` from the reset style here and move that to the shared-package .scss so other apps can inherit the pointer hover styling. Secondly, the Menu item should get cursor:pointer styling in the respect MenuItem.scss module.

Finally, an audit of all input[type=] should be done. I did not find any instances of these `reset` or `submit` and so perhaps the entire css rule here in reset.scss can be removed.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.