hypothesis / hypothesis/client

Newly created annotations "disappear" from sidebar if there is an existing selection

Open
#3,220 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
Mustache
Stars
730
Forks
224
PR merge metrics
No merged PRs in 30d

Description

When a new annotation is created while there is an existing selection, the new annotation will "disappear" after it is saved. I put "disappear" in quotes because the annotation is still present and is saved, its just not visible because it isn't in the current selection.

To see the problem:

1. Create a new annotation and save it
2. Click on the corresponding highlight in the document. This will create a selection in the sidebar so that only the annotation created in step 1 is visible
3. Start creating another annotation and save it.

In Step 3 the draft annotation will appear in the sidebar in addition to the previously selected highlight. When the new annotation is saved however, it disappears and only the previously selected annotation is visible.

I believe this is currently expected, but I think it is not the desirable behavior. I think the new annotation created in step 3 should remain visible after it is saved.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.