hypothesis / hypothesis/client

Some config settings may be casted in hostPageSetting() in the annotator

Open
#2,098 1 comment 0 reactions 0 assignees View on GitHub
technical debt
Dominant language
Mustache
Stars
730
Forks
224
PR merge metrics
No merged PRs in 30d

Description

Currently only the `openSidebar` setting is coerced, but other settings could be coerced for consistency. Some of these values may come from via in which case via will only produce string values.

from `annotator/config/index.js`

```
openSidebar: settings.hostPageSetting('openSidebar', {
allowInBrowserExt: true,
coerce: toBoolean,
}),
```

_Note. Some of the settings in are not actually used in the annotator and so there is no specific need to coerce them other than for consistency with `openSidebar` and with how they are coerced in `host-config.js` for the sidebar._

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.