hypherionmc / hypherionmc/sdlink

[Bug]: /save-all or /stop does not work on discord

Open
#206 5 comments 0 reactions 0 assignees View on GitHub
Not Fixable: Bug in other mod Type: Bug
Dominant language
Java
Stars
38
Forks
26
PR merge metrics
No merged PRs in 30d

Description

### 🐞 Description

If I use command such as /save-all or /stop, the server refuses it and send this log

[11:59:09] [pool-12-thread-1/ERROR]: Command exception: /save-all
java.util.ConcurrentModificationException: Attempted to tick tickets asynchronously
at knot/net.minecraft.class_3204.redirect$ele000$vmp$tickTickets(class_3204.java:1617) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_3204.method_15892(class_3204.java:120) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_3215.method_16155(class_3215.java:267) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_3215.method_17298(class_3215.java:289) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_3218.method_14176(class_3218.java:820) ~[server-intermediary.jar:?]
at knot/net.minecraft.server.MinecraftServer.method_3723(MinecraftServer.java:556) ~[server-intermediary.jar:?]
at knot/net.minecraft.server.MinecraftServer.method_39218(MinecraftServer.java:580) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_3104.method_13550(class_3104.java:32) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_3104.method_13549(class_3104.java:20) ~[server-intermediary.jar:?]
at knot/com.mojang.brigadier.context.ContextChain.runExecutable(ContextChain.java:73) ~[brigadier-1.3.10.jar:?]
at knot/net.minecraft.class_8865.method_54416(class_8865.java:29) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_8865.execute(class_8865.java:13) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_8856.method_54405(class_8856.java:8) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_8847.method_54388(class_8847.java:8) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_8854.method_54390(class_8854.java:107) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_2170.method_54313(class_2170.java:379) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_2170.method_9249(class_2170.java:309) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_2170.method_44252(class_2170.java:299) ~[server-intermediary.jar:?]
at knot/com.hypherionmc.craterlib.nojang.server.BridgedMinecraftServer.executeCommand(BridgedMinecraftServer.java:92) ~[CraterLib-Fabric-1.21-3.0.1.jar:?]
at knot/com.hypherionmc.sdlink.platform.SDLinkMCPlatform.executeCommand(SDLinkMCPlatform.java:23) ~[SimpleDiscordLink-Universal-3.3.4.jar:?]
at knot/com.hypherionmc.sdlink.server.SDLinkMinecraftBridge.executeMinecraftCommand(SDLinkMinecraftBridge.java:113) ~[SimpleDiscordLink-Universal-3.3.4.jar:?]
at knot/com.hypherionmc.sdlink.core.discord.hooks.MinecraftCommandHook.executeCommand(MinecraftCommandHook.java:89) ~[SimpleDiscordLink-Universal-3.3.4.jar:?]
at knot/com.hypherionmc.sdlink.core.discord.hooks.MinecraftCommandHook.discordMessageEvent(MinecraftCommandHook.java:69) ~[SimpleDiscordLink-Universal-3.3.4.jar:?]
at knot/com.hypherionmc.sdlink.core.discord.events.DiscordEventHandler.onMessageReceived(DiscordEventHandler.java:100) ~[SimpleDiscordLink-Universal-3.3.4.jar:?]
at knot/com.hypherionmc.sdlink.shaded.dv8tion.jda.api.hooks.ListenerAdapter.onEvent(ListenerAdapter.java:456) ~[SimpleDiscordLink-Universal-3.3.4.jar:?]
at knot/com.hypherionmc.sdlink.shaded.dv8tion.jda.api.hooks.InterfacedEventManager.handle(InterfacedEventManager.java:98) ~[SimpleDiscordLink-Universal-3.3.4.jar:?]
at knot/com.hypherionmc.sdlink.util.ThreadedEventManager.lambda$handle$0(ThreadedEventManager.java:26) ~[SimpleDiscordLink-Universal-3.3.4.jar:?]
at java.base/java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1804) ~[?:?]
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144) ~[?:?]
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642) ~[?:?]
at java.base/java.lang.Thread.run(Thread.java:1583) [?:?]

### 🔄 Steps to reproduce

Open the server, do /save-all or /stop on discord server command

### ✅ Expected behavior

it should execute the command

### ❌ Actual behavior

The command do not work and send error log

### 🎮 Minecraft Version

1.21.1

### 🛠️ Mod Version

3.3.4

### 📦 Mod Loader

Fabric

### 🔧 Mod Loader Version

0.18.1

### 📚 CraterLib Version

3.0.1

### 📜 Logs & Screenshots

[11:59:09] [pool-12-thread-1/ERROR]: Command exception: /save-all
java.util.ConcurrentModificationException: Attempted to tick tickets asynchronously
at knot/net.minecraft.class_3204.redirect$ele000$vmp$tickTickets(class_3204.java:1617) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_3204.method_15892(class_3204.java:120) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_3215.method_16155(class_3215.java:267) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_3215.method_17298(class_3215.java:289) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_3218.method_14176(class_3218.java:820) ~[server-intermediary.jar:?]
at knot/net.minecraft.server.MinecraftServer.method_3723(MinecraftServer.java:556) ~[server-intermediary.jar:?]
at knot/net.minecraft.server.MinecraftServer.method_39218(MinecraftServer.java:580) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_3104.method_13550(class_3104.java:32) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_3104.method_13549(class_3104.java:20) ~[server-intermediary.jar:?]
at knot/com.mojang.brigadier.context.ContextChain.runExecutable(ContextChain.java:73) ~[brigadier-1.3.10.jar:?]
at knot/net.minecraft.class_8865.method_54416(class_8865.java:29) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_8865.execute(class_8865.java:13) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_8856.method_54405(class_8856.java:8) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_8847.method_54388(class_8847.java:8) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_8854.method_54390(class_8854.java:107) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_2170.method_54313(class_2170.java:379) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_2170.method_9249(class_2170.java:309) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_2170.method_44252(class_2170.java:299) ~[server-intermediary.jar:?]
at knot/com.hypherionmc.craterlib.nojang.server.BridgedMinecraftServer.executeCommand(BridgedMinecraftServer.java:92) ~[CraterLib-Fabric-1.21-3.0.1.jar:?]
at knot/com.hypherionmc.sdlink.platform.SDLinkMCPlatform.executeCommand(SDLinkMCPlatform.java:23) ~[SimpleDiscordLink-Universal-3.3.4.jar:?]
at knot/com.hypherionmc.sdlink.server.SDLinkMinecraftBridge.executeMinecraftCommand(SDLinkMinecraftBridge.java:113) ~[SimpleDiscordLink-Universal-3.3.4.jar:?]
at knot/com.hypherionmc.sdlink.core.discord.hooks.MinecraftCommandHook.executeCommand(MinecraftCommandHook.java:89) ~[SimpleDiscordLink-Universal-3.3.4.jar:?]
at knot/com.hypherionmc.sdlink.core.discord.hooks.MinecraftCommandHook.discordMessageEvent(MinecraftCommandHook.java:69) ~[SimpleDiscordLink-Universal-3.3.4.jar:?]
at knot/com.hypherionmc.sdlink.core.discord.events.DiscordEventHandler.onMessageReceived(DiscordEventHandler.java:100) ~[SimpleDiscordLink-Universal-3.3.4.jar:?]
at knot/com.hypherionmc.sdlink.shaded.dv8tion.jda.api.hooks.ListenerAdapter.onEvent(ListenerAdapter.java:456) ~[SimpleDiscordLink-Universal-3.3.4.jar:?]
at knot/com.hypherionmc.sdlink.shaded.dv8tion.jda.api.hooks.InterfacedEventManager.handle(InterfacedEventManager.java:98) ~[SimpleDiscordLink-Universal-3.3.4.jar:?]
at knot/com.hypherionmc.sdlink.util.ThreadedEventManager.lambda$handle$0(ThreadedEventManager.java:26) ~[SimpleDiscordLink-Universal-3.3.4.jar:?]
at java.base/java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1804) ~[?:?]
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144) ~[?:?]
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642) ~[?:?]
at java.base/java.lang.Thread.run(Thread.java:1583) [?:?]

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.