hyperweb-io / hyperweb-io/telescope

defaults for descriptor enum

Open
#77 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
154
Forks
53
PR merge metrics
No merged PRs in 30d

Description

NOTE: proto3 enforces enums starting at 0, however proto2 does not, so we have to decide if this is necessary or not.

`google/protobuf/descriptor`

```
- label: 1,
- type: 1,
+ label: 0,
+ type: 0,
```

```
}

- if (message.label !== 1) {
+ if (message.label !== 0) {
writer.uint32(32).int32(message.label);
}

- if (message.type !== 1) {
+ if (message.type !== 0) {
writer.uint32(40).int32(message.type);
}
```

```js
name: isSet(object.name) ? String(object.name) : "",
number: isSet(object.number) ? Number(object.number) : 0,
- label: isSet(object.label) ? fieldDescriptorProto_LabelFromJSON(object.label) : 1,
- type: isSet(object.type) ? fieldDescriptorProto_TypeFromJSON(object.type) : 1,
+ label: isSet(object.label) ? fieldDescriptorProto_LabelFromJSON(object.label) : 0,
+ type: isSet(object.type) ? fieldDescriptorProto_TypeFromJSON(object.type) : 0,
typeName: isSet(object.typeName) ? String(object.typeName) : "",
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.