hyperweb-io / hyperweb-io/telescope

some params not getting picked up

Open
#611 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
154
Forks
53
PR merge metrics
No merged PRs in 30d

Description

low priority, since it's mostly for LCD, which is technically deprecated

https://github.com/cosmology-tech/telescope/blob/85d83dc66d87ac9cc2890bc30c0b22c2d67d61c1/__fixtures__/osmojs/ibc-go/proto/ibc/applications/fee/v1/query.proto#L36-L39

https://github.com/cosmology-tech/telescope/blob/85d83dc66d87ac9cc2890bc30c0b22c2d67d61c1/__fixtures__/v-next/outputosmojs/ibc/applications/fee/v1/query.lcd.ts#L72-L74

Notice the `_params` thinks it's empty, but it's NOT:

```ts
async totalAckFees(_params: QueryTotalAckFeesRequest = {}): Promise {
const endpoint = `ibc/apps/fee/v1/channels/${params.packetId.channel_id}/ports/${params.packetId.port_id}/sequences/${params.packetId.sequence}/total_ack_fees`;
return QueryTotalAckFeesResponse.fromSDKJSON(await this.req.get(endpoint));
}
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.