hyperweb-io / hyperweb-io/telescope

New typeUrl/$typeUrl field causing issues in testing frameworks

Open
#489 7 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
154
Forks
53
PR merge metrics
No merged PRs in 30d

Description

Before Telescope 1.0, the generated messages only contained the object fields that are present in the protobuf `message` declaration. Now, the meta field `typeUrl`/`$typeUrl` is added. This causes issues when using the message in testing frameworks that do equality checks.

Bildschirmfoto 2023-10-23 um 17 00 34

I know I somwwhat requested that addition. But seeing the consequences now I think it's not a great way to implement the feature. Ideally we can keep the proto fields and meta fields separate. Maybe it's better to add the type URL on the type instead of the instance. If you have ideas for this, let me know.

In the meantime I'll use this for cosmjs-types:

```
prototypes: {
addTypeUrlToDecoders: false,
addTypeUrlToObjects: false,
}
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.