hyperweb-io / hyperweb-io/starship

bugs: v2 generator list of bugs on comparisions

Open
#720 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
77
Forks
39
PR merge metrics
No merged PRs in 30d

Description

## Overview
A couple of issues with the generator:
- [x] configmaps structure: extra new lines in configmaps for scripts loaded
- [x] registry cofigmap is incorrect, need configmaps per chain instead of a single configmap with half required lists
- [x] targetPort in service seems to be a string in kubernetesjs, but a number in helm export. Need to verify
- [ ] mertrics port present in service even if monitoring is disabled
- [x] selector is incorrect in registry service: ` selector: {app: registry}` instead of k8s label
- [x] ports inside container spec for deployment, explorer, not needed
- [ ] mountpath incorrect for explorer: should be `/home/explorer/chains/mainnet` got `/explorer`
- [ ] command missing from explorer Deployment
- [ ] `readinessProbe` and `livenessProbe` missing in explorer deployment
- [ ] `selector` incorrect in registry deployment
- [ ] `template.metadata.labels` is incoorect in registry deployment
- [ ] no `initContainer` for waiting for chains before registry deployment
- [ ] `imagePullPolicy` missing in registry deployment container
- [ ] `env` missing some fields in registry deployment: `NAMESPACE`, `REGISTRY_CHAIN_CLIENT_IDS`, `REGISTRY_CHAIN_CLIENT_NAMES`
- [ ] `env.REGISTRY_CHAIN_CLIENT_RPCS` inncorect in registry deployment
- [ ] incorrect `readinessProbe`, should be `tcpSocket` for both in registry deployment
- [ ] inncorect volumes for configmaps in registry deployments
- [x] `TIMEOUT_*` env missing in genesis statefulsets for cosmos
- [ ] `faucet` volumeMount extra in validator statefulset
- [x] wrong image in relayer `init-exposer`
- [x] `wait-for-chains` is wrong for hermes relayers
- [ ] `RELAYER_INDEX` wrongly set in env for hermes relayer statefulsets
- [x] `osmosis-1-cli` not added properly in `init-relayer`
- [ ] resources not propogated in `init-relayers` same as the main resources
- [x] resources for validator node not same as genesis node.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.