hyperweb-io / hyperweb-io/starship

improvements: Add ability to specify multiple denoms in values.yaml

Open
#72 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
TypeScript
Stars
77
Forks
39
PR merge metrics
No merged PRs in 30d

Description

## Overview
Currently we are using `coins: 100000000000000uosmo,100000000000000uion` and `denom` in the default `values.yaml` file in `defaultChains`.

The side effect of this is, the registry service is currently only able to show a single denom in the assetlist.

## Proposal
Ability to specify multiple denoms as per the chain in the default values (based on the actual chain-registry)
```yaml
defaultChains:
osmosis:
image: anmol1696/osmosis:latest
home: /root/.osmosisd
binary: osmosisd
prefix: osmo
denom: uosmo
denoms:
- name: osmo
# ", "
units: "uosmo, osmo"
- name: ion
units: "uion, ion"
coins: 100000000000000uosmo,100000000000000uion
hdPath: m/44'/118'/0'/0/0
coinType: 118
repo: https://github.com/osmosis-labs/osmosis
```

Add tests in the e2e package to make sure this runs always

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.