hyperweb-io / hyperweb-io/chain-registry

cleanup method names and update cca examples

Open
#48 0 comments 0 reactions 2 assignees Claimed by @marslavish View on GitHub
Dominant language
TypeScript
Stars
70
Forks
39
PR merge metrics
No merged PRs in 30d

Description

Asset (for ATOM):
base: uatom
display: atom
symbol: ATOM

> Symbol is best for user facing and when you need simplicity.
> Base is good for being the only one guaranteed to be unique per chain.
> The word ‘Display’ I would avoid entirely for these functions.
> And Denom is a bit ambiguous, but is the terminology I see being used on-chain.
> Since we’re just starting to see symbol collisions, I guess Id recommend Denom or Symbol, but also allow for chain name just to avoid ambiguity.
> So getPriceByDenom(uatom, cosmoshub) or getPriceByDenom(uatom) would work.
> And getPriceBySymbol(ATOM) would work and getPriceBySymbol(NOM,onomy) would also work, but getPriceBySymbol(NOM) would fail (or return an array or something) due to the two possibilities.

cc @HebeHe1986

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.