hyperstack-org / hyperstack-org/hyperstack

hyper-trace issues

Open
#404 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
538
Forks
41
PR merge metrics
No merged PRs in 30d

Description

1. Need to add exception exclusions to Operations... i.e. add this method:

```ruby
def hypertrace_class_exclusions
[ list of expected internal exceptions ]
end
```
define at both class and instance level.

2. Operations checks the arity of the method to decide whether to forward the parameters, but hypertrace accepts *args (arity -1) this confuses operations and ends up passing a value along. Have to have some way to tell hyperoperation what the real arity was.

3. line 202 needs a guard so that if parameters is not available we leave well enough alone. (make sure return unless specs works when specs is javascript undefined)

```ruby
def map_with_specs(method, actual, show_blank_rest)
specs = method.parameters
return unless specs
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.