hyperstack-org / hyperstack-org/hyperstack

Missing inverse of has_many :though not detected

Open
#298 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
538
Forks
41
PR merge metrics
No merged PRs in 30d

Description

consider

```ruby
class Physician < ActiveRecord::Base
has_many :appointments
has_many :patients, through: :appointments
end

class Appointment < ActiveRecord::Base
belongs_to :physician
belongs_to :patient
end

class Patient < ActiveRecord::Base
has_many :appointments
has_many :physicians, through: :appointments
end
```

now if we define `Physician#patients` as `has_many :patients` (i.e. without the through) and then do this:

```ruby
old_physician = Physician.find_by_name('Foo')
new_patient = Patient.new(name: 'new guy')
appt = Appointment.new(physician: old_physician, patient: new_patient)
```

we would find on the server that

```ruby
new_patient.physicians
```

is `[]`

but on the client the list is empty. So it seems that Rails is inferring (or not even caring about) the missing inverse `has_many though:` on `Physician` (since we are not accessing it), but hyperstack is failing for some reason.

Of course if we can infer the relationship (per Rails) that is great, but at least there should be a warning or error so you can fix it.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.