hyperoslo / hyperoslo/ios-foundation

Delegate methods

Open
#42 11 comments 3 reactions 0 assignees View on GitHub
discussion
Dominant language
Ruby
Stars
5
Forks
0
PR merge metrics
No merged PRs in 30d

Description

It got a bit inspired by http://khanlou.com/2016/09/swifty-delegates/ that @onmyway133 shared in the previous discussion. So I wanted to run some stuff by you when building delegate methods.

I would propose that we start moving towards what the article is describing.
To give you a concrete example from the Spots Swift 3 migration.
I'd like to change the public API for the `SpotsDelegate` method that gets invoked whenever someone taps on an item.
## Before

``` swift
func spotDidSelectItem(_ spot: Spotable, item: Item)
```
## After

``` swift
func didSelect(item: Item, in spot: Spotable)
```

I think that reads much nicer.

What do you guys think? @hyperoslo/ios

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.