hyperoslo / hyperoslo/Cache

Accessing allObjects from DiskStorage

Open
#334 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Swift
Stars
3.1k
Forks
355
PR merge metrics
No merged PRs in 30d

Description

I've noticed an issue with the allObjects property in the DiskStorage implementation. The current default implementation returns an empty array, making it impossible to access any stored objects. Also, as of now there is no way to get allObjects from disk when they are not in memory?

The relevant code snippet from DiskStorage is as follows:

```
extension DiskStorage: StorageAware {
public var allKeys: [Key] { [] }

public var allObjects: [Value] { [] }
}
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.