hyperoslo / hyperoslo/Cache

memoryConfig not optional for Storage.init as comment says.

Open
#330 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Swift
Stars
3.1k
Forks
355
PR merge metrics
No merged PRs in 30d

Description

``` /// Initialize storage with configuration options.
///
/// - Parameters:
/// - diskConfig: Configuration for disk storage
/// - memoryConfig: *Optional*. Pass config if you want memory cache
/// - Throws: Throw StorageError if any.
public convenience init(diskConfig: DiskConfig, memoryConfig: MemoryConfig, transformer: Transformer) throws {
let disk = try DiskStorage(config: diskConfig, transformer: transformer)
let memory = MemoryStorage(config: memoryConfig)
let hybridStorage = HybridStorage(memoryStorage: memory, diskStorage: disk)
self.init(hybridStorage: hybridStorage)
}
```

This says `memoryConfig` should be Optional, but it's not. Not sure which is the typo.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.