hyperoslo / hyperoslo/BarcodeScanner
Remove - while setting collapsed constraints for MessageViewController
- Dominant language
- Swift
- Stars
- 1.7k
- Forks
- 383
- PR merge metrics
- No merged PRs in 30d
Description
Sorry for not openning PR, I made a lot of changes, so dont want to push it here :)
```
private func makeCollapsedConstraints() -> [NSLayoutConstraint] {
return [
messageView.bottomAnchor.constraint(equalTo: view.bottomAnchor),
messageView.leadingAnchor.constraint(equalTo: view.leadingAnchor),
messageView.trailingAnchor.constraint(equalTo: view.trailingAnchor),
messageView.heightAnchor.constraint(
equalToConstant: hideFooterView ? 0 : -BarcodeScannerViewController.footerHeight
)
]
}
```
Here I think `-BarcodeScannerViewController.footerHeight` should be `BarcodeScannerViewController.footerHeight` height can not be negative.
Contributor guide
Assessment
This issue has not been assessed yet.