hyperlight-dev / hyperlight-dev/hyperlight

max_guest_log_level is not plumbed through snapshot load

Open
#1,698 1 comment 0 reactions 0 assignees View on GitHub
lifecycle/confirmed
Dominant language
Rust
Stars
4.7k
Forks
208
Avg merge
1d 7h
Merged PRs (30d)
47

Description

### What happened?

After https://github.com/hyperlight-dev/hyperlight/pull/1465 is merged,

max_guest_log_level is not plumbed through snapshot load.

### Steps to Reproduce

1. Run '...'
2. And then do '...'
3. Check logs for '...'

### Expected Results

log level to be set when working with snapshot loads.

### Actual Results

TODO: What actually happened?

### Versions and Environment

Hyperlight version or commit: TODO

#### OS Version

Run the following to find your OS version:

Linux:
```console
cat /etc/os-release && uname -a
```

Windows (PowerShell):
```powershell
cmd /c ver
```

#### Hypervisor

Run the following to check hypervisor access:

Linux:
```console
ls -la /dev/kvm /dev/mshv 2>&1; getfacl /dev/kvm /dev/mshv 2>&1; id
[ -r /dev/kvm ] && [ -w /dev/kvm ] && echo "KVM: OK" || echo "KVM: FAIL"
[ -r /dev/mshv ] && [ -w /dev/mshv ] && echo "MSHV: OK" || echo "MSHV: FAIL"
```

Windows (Admin PowerShell):
```powershell
Get-WindowsOptionalFeature -Online | Where-Object {$_.FeatureName -match 'Hyper-V|HypervisorPlatform|VirtualMachinePlatform'} | Format-Table
```

### Extra Info

Anything else you'd like to add?

Contributor guide

Open the contributing guide

Research direction

Start by tracing the snapshot load path and the handling of max_guest_log_level, using the linked pull request for context. Reproduce the snapshot-loading case described in the issue, then verify that the guest log level is set during snapshot loads and add or update coverage if the relevant test location is found.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
operating-systems
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.