hyperlight-dev / hyperlight-dev/hyperlight-wasm

Avoid commiting vendor.tar in the repo

Open
#88 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

lifecycle/confirmed
Dominant language
Rust
Stars
728
Forks
39
Avg merge
2d 6h
Merged PRs (30d)
23

Description

Honestly, I don't have a strong concern (except for maybe something about the repository size); I just really don't like committing built artifacts if it can be helped, especially because keeping them in sync always seems to be a bit of a pain.

I was thinking that cargo basically is just checking git HEAD == git index == working-tree, so we could just do our own script that checks git HEAD == git index and git index == working-tree - vendor.tar (and vendor.tar matches working tree/index for the things it should have in it). Totally up to you though :)

Originally posted by @syntactically in https://github.com/hyperlight-dev/hyperlight-wasm/pull/83#discussion_r2174555543

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the Cargo workflow and the repository state checks described in the issue, including how vendor.tar is produced and kept in sync. Done means establishing whether the artifact can be omitted and defining checks for git HEAD, the index, the working tree, and vendor.tar contents.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, rust
Domain
build-system, tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.