Elminate ENV VAR to configure build

Open
#223 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Quiet
Tech stack
rust
Domain
build-system

Research direction

Start by locating where the build reads the environment variable and how the guest runtime is selected. Review the existing build configuration before deciding how the runtime and any native-library or precompiled-runtime paths should be specified without that variable. Done means the build no longer depends on the environment variable and still selects the guest runtime successfully.

Written by the indexing model from the issue text.

Description

lifecycle/needs-review

I am not a big fan of using env-vars to configure the build, but it works.
In the future I would like to explore if we can use a macro to specify the guest runtime, we can specify native libraries to add as arguments to the macro, or the path to a precompiled runtime, etc.
But that would be a major refactor, and this is good enough.

Originally posted by @jprendes in https://github.com/hyperlight-dev/hyperlight-js/pull/49#pullrequestreview-4618377333

Dominant language
Rust
Stars
13
Forks
5
Avg merge
8d 10h
Merged PRs (30d)
13

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from hyperlight-dev/hyperlight-js

All issues in hyperlight-dev/hyperlight-js

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.