hyperledger / hyperledger/fabric-private-chaincode

CI, Golint Check before building PR

Open
#729 4 comments 0 reactions 0 assignees View on GitHub
feature help wanted
Dominant language
Go
Stars
174
Forks
98
Avg merge
2d 21h
Merged PRs (30d)
1

Description

**Is your feature request related to a problem? Please describe.**
I had a Golang lint error after 20 minutes of docker build. Maybe we can add a new Golint checking before building docker image in CI.

**Describe the solution you'd like**
Current CI Flow:
```
Set up job
Run actions/checkout@v4
Run dorny/paths-filter@v2
build dev image
fetch dev image
run make inside dev container
....
```

Suggest CI Flow:
```
Set up job
Run actions/checkout@v4
Run dorny/paths-filter@v2
golint checking
build dev image
fetch dev image
run make inside dev container
....
```

**Describe alternatives you've considered**
Or any step before run make inside dev container

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.