hyperledger-labs / hyperledger-labs/perun-node

grpc api: Session close should also close corresponding listeners for proposal and updates

Open
#246 0 comments 0 reactions 0 assignees View on GitHub
improvement
Dominant language
Go
Stars
18
Forks
12
PR merge metrics
No merged PRs in 30d

Description

#### Motivation / Context

In the current implementation a session can be closed and the listeners are still open.

Expectation is that only if a session is open, listeners are valid and existent.

Maybe an alternative option is to add a flag to the method (true/false), which is targeting closing corresponding listeners if set to true. Default it will be false and preserve open listeners.

#### Description

Session close should also contain the following logic:

- Check for open channel proposal listeners for that session.
- Close found channel proposal listeners.
- Check for open channel update listeners.
- Close found channel update listeners.

##### Relates to

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.