hyperledger-labs / hyperledger-labs/perun-node

Handle the case when watcher returns before the channel is closed

Open
#197 0 comments 0 reactions 0 assignees View on GitHub
improvement
Dominant language
Go
Stars
18
Forks
12
PR merge metrics
No merged PRs in 30d

Description

#### Motivation / Context

Currently, the watcher is started when a channel is opened (see `newCh` function in `session/channel.go` and assumed that it will only return after the channel instance from go-perun is closed. So we just log the error.

This assumption holds good for all our current tests cases, but the cases where the assumption will fail also should be handled. #### Description

Explore when this assumption can fail and handle the error for such cases. One possible scenario where it fails could be when connection to blockchain fails.

##### Relates to

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.