hyperledger-identus / hyperledger-identus/cloud-agent

[Doc not up to date] Creating VC Offer

Open
#1,213 2 comments 0 reactions 0 assignees View on GitHub
question
Dominant language
Scala
Stars
95
Forks
34
Avg merge
1d 5h
Merged PRs (30d)
14

Description

### Is this a regression?

No

### Description

The Doc https://docs.atalaprism.io/agent-api/#tag/Issue-Credentials-Protocol/operation/createCredentialOffer is very misleading., and the change to Identus v1.33.0 seems to be more restrictive on params, which makes it very hard to understand what works / what does not work, as the doc is not clear.

The doc states the params must be {
"validityPeriod": 3600,
"schemaId": "https://agent-host.com/cloud-agent/schema-registry/schemas/d9569cec-c81e-4779-aa86-0d5994d82676/schema",
"credentialDefinitionId": "d9569cec-c81e-4779-aa86-0d5994d82676",
"credentialFormat": "JWT",
"claims": {
"firstname": "Alice",
"lastname": "Wonderland"
},
"automaticIssuance": true,
"issuingDID": "did:prism:3bb0505d13fcb04d28a48234edb27b0d4e6d7e18a81e2c1abab58f3bbc21ce6f",
"connectionId": "d9569cec-c81e-4779-aa86-0d5994d82676"
}

1/ this comes up with undocumented internal errors "$: required property 'attrNames' not found; $: required property 'issuerId' not found"

2/ it was recommended to remove the credentialDefinitionId but then it comes up with another undocumented internal error : status 400 ; Failed to parse schema content as Json or OEA: .guid(missing)

3/ then it was recommended to put "schemaId": null, and it worked...

what should be done:
- update the doc to make a WORKING example using NO schema, and NO Definition
- update the doc to make a WORKING example using schema, but NO Definition
- update the doc to make a WORKING example using Definition (with or without Schema)
- update the doc to make a WORKING example for AnonCreds
- document all possible errors correctly

### Please provide the exception or error you saw

```Markdown
see above
```

### Please provide the environment you discovered this bug in

```Markdown
Identus V1.33.0
```

### Anything else?

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.