hyperledger-firefly / hyperledger-firefly/firefly

Adjust queries for operations that use only a transaction ID

Open
#644 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
602
Forks
246
Avg merge
18h 47m
Merged PRs (30d)
6

Description

There are a few queries to `GetOperations` that attempt to load operation inputs only by looking at the operation type and the transaction ID. One example:

https://github.com/hyperledger/firefly/blob/47ae1fd858c9eeb68705bfd58e3650da543c37e4/internal/events/tokens_transferred.go#L36

Due to operation resubmission, transactions may now contain multiple operations of a given type, meaning that there is a potential source of confusion here in terms of _which_ operation is loaded. It may not matter if all the operations have identical inputs (which is currently the case for retries) - but worth double-checking that this doesn't cause problems now or in the future.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.