hyperledger-firefly / hyperledger-firefly/firefly

All events fail to process on a node if the source event's plugin configuration is missing

Open
#366 3 comments 0 reactions 1 assignee Claimed by @awrichar View on GitHub
Dominant language
Go
Stars
602
Forks
246
Avg merge
18h 47m
Merged PRs (30d)
6

Description

Steps to reproduce:
- Create FF node1 configured **with** the erc1155 tokens plugin
- Create a token pool / mint some tokens on FF node1
- Create and add FF node2 to the network configured **without** the erc1155 tokens plugin
- FF node2 fails to process the tokens events and gets stuck in an overall event processing rollback. It seems like this rollback prevents other non token events from processing and therefore prevents the org from registering itself in the network

Expected behavior:
I would expect events received from a plugin that is not configured on a node to be ignored / handled appropriately until that plugin is configured on that node

logs snippet from FF node2:
```
[] INFO Node not yet registered pid=284
[] INFO Confirming system broadcast 'ff_define_node' [3760c6f0-da92-4610-8da6-31efb3edbf7f] dbtx=urGDLcz7 pid=284 role=aggregator
[] INFO ==> PUT http://localhost:4000/api/v1/peers/Kaleido-zzg7nwrkr3 breq=i2CSTj7B dx=https pid=284
[] INFO <== PUT http://localhost:4000/api/v1/peers/Kaleido-zzg7nwrkr3 [200] (104.76ms) breq=i2CSTj7B dx=https pid=284
[] INFO Emitting message_confirmed for message ff_system:3760c6f0-da92-4610-8da6-31efb3edbf7f dbtx=urGDLcz7 pid=284 role=aggregator
[] INFO Confirming system broadcast 'ff_define_pool' [34583289-1072-4e65-ba77-b9c9726a3a82] dbtx=urGDLcz7 pid=284 role=aggregator
[] ERROR Failed to activate token pool 'd4b913a5-5482-41e2-9100-493abbd724f1': FF10272: Unknown tokens plugin 'erc1155' dbtx=urGDLcz7 pid=284 role=aggregator
[] WARN SQL! transaction rollback dbtx=urGDLcz7 pid=284 role=aggregator
[] ERROR process events attempt 1: FF10272: Unknown tokens plugin 'erc1155' pid=284 role=ep[ff_system:ff_aggregator]
[] INFO Confirming system broadcast 'ff_define_node' [3760c6f0-da92-4610-8da6-31efb3edbf7f] dbtx=BxMYSRuO pid=284 role=aggregator
[] INFO ==> PUT http://localhost:4000/api/v1/peers/Kaleido-zzg7nwrkr3 breq=Y0MYmZ0_ dx=https pid=284
[] INFO <== PUT http://localhost:4000/api/v1/peers/Kaleido-zzg7nwrkr3 [200] (73.50ms) breq=Y0MYmZ0_ dx=https pid=284
[] INFO Emitting message_confirmed for message ff_system:3760c6f0-da92-4610-8da6-31efb3edbf7f dbtx=BxMYSRuO pid=284 role=aggregator
[] INFO Confirming system broadcast 'ff_define_pool' [34583289-1072-4e65-ba77-b9c9726a3a82] dbtx=BxMYSRuO pid=284 role=aggregator
[] ERROR Failed to activate token pool 'd4b913a5-5482-41e2-9100-493abbd724f1': FF10272: Unknown tokens plugin 'erc1155' dbtx=BxMYSRuO pid=284 role=aggregator
[] WARN SQL! transaction rollback dbtx=BxMYSRuO pid=284 role=aggregator
[] ERROR process events attempt 2: FF10272: Unknown tokens plugin 'erc1155' pid=284 role=ep[ff_system:ff_aggregator]
[] INFO Node not yet registered pid=284
.... (reattempt sequence repeats)
[] INFO <-- POST /api/v1/network/organizations/self [408] (120003.10ms): FF10260: The request with id '...' timed out after 119,298.88ms httpreq=lsvN1NrO pid=146 req=ho3P3xSP
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.