hyperledger-firefly / hyperledger-firefly/fabconnect

Inconsistent transactionId field name on receipts/events

Open
#74 0 comments 0 reactions 1 assignee Claimed by @jimthematrix View on GitHub
bug
Dominant language
Go
Stars
40
Forks
27
PR merge metrics
No merged PRs in 30d

Description

We have a mix of:
- `transactionHash`
- `transactionID`
- `transactionId`

Receipts seem to be the place that should change:
https://github.com/hyperledger/firefly-fabconnect/blob/9b005b6664e65e3e0645cd5d5c03c6c9c9354a0e/internal/messages/messages.go#L140-L155

To match events which use `transactionId`:
https://github.com/hyperledger/firefly-fabconnect/blob/afde10c5c4139db48f2695d3845ddc9b15a45817/internal/events/api/event.go#L64-L73

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.