hyperledger-firefly / hyperledger-firefly/fabconnect
Parameter handling is inconsistent
Open
- Dominant language
- Go
- Stars
- 40
- Forks
- 27
- PR merge metrics
- No merged PRs in 30d
Description
Currently, parameters that are objects are not encoded as strings, however, arrays are.
Object parameter: https://github.com/hyperledger/firefly-fabconnect/blob/main/internal/rest/utils/params_test.go#L91
Array parameter: https://github.com/hyperledger/firefly-fabconnect/blob/main/internal/rest/utils/params_test.go#L306
This is not consistent, and begs the question how to pass objects with nested arrays and arrays of objects.
Tests are missing for `objectArray`.
Firefly is sending objects encoded as strings, and this results in errors, see:
https://github.com/hyperledger/firefly/issues/1307
Contributor guide
Assessment
This issue has not been assessed yet.